linux-kernel - Re: [patch 4/8] x86/tsc: Verify TSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161129142509.GA23458@gmail.com>
Date:   Tue, 29 Nov 2016 15:25:10 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Borislav Petkov <bp@...en8.de>, Yinghai Lu <yinghai@...nel.org>
Subject: Re: [patch 4/8] x86/tsc: Verify TSC_ADJUST from idle


* Thomas Gleixner <tglx@...utronix.de> wrote:

> On Mon, 21 Nov 2016, Peter Zijlstra wrote:
> > On Mon, Nov 21, 2016 at 09:16:44AM +0100, Thomas Gleixner wrote:
> > > On Sun, 20 Nov 2016, Peter Zijlstra wrote:
> > > > On Sat, Nov 19, 2016 at 01:47:37PM -0000, Thomas Gleixner wrote:
> > > > > When entering idle, it's a good oportunity to verify that the TSC_ADJUST
> > > > > MSR has not been tampered with (BIOS hiding SMM cycles). If tampering is
> > > > > detected, emit a warning and restore it to the previous value.
> > > > 
> > > > > +++ b/arch/x86/kernel/process.c
> > > > > @@ -277,6 +277,7 @@ void exit_idle(void)
> > > > >  
> > > > >  void arch_cpu_idle_enter(void)
> > > > >  {
> > > > > +	tsc_verify_tsc_adjust();
> > > > >  	local_touch_nmi();
> > > > >  	enter_idle();
> > > > >  }
> > > > 
> > > > Doing a RDMSR on the idle path isn't going to be popular. That path is
> > > > already way too slow.
> > > 
> > > Of course we can ratelimit that MSR read with jiffies, but do you have any
> > > better suggestion aside of doing it timer based?
> > 
> > Not really :/ 
> 
> Revamped patch below.

The whole series:

  Reviewed-by: Ingo Molnar <mingo@...nel.org>

	Ingo