linux-kernel - Re: [PATCH] leds: netxbig: fix module autoload for OF registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f84c025-7835-1664-60df-092b80a4ade7@osg.samsung.com>
Date:   Tue, 29 Nov 2016 12:00:30 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:     linux-kernel@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: netxbig: fix module autoload for OF registration

Hello Jacek,

On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
> alias:          platform:leds-netxbig
> 
> After this patch:
> 
> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
> alias:          platform:leds-netxbig
> alias:          of:N*T*Clacie,netxbig-ledsC*
> alias:          of:N*T*Clacie,netxbig-leds
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
> 

Any comments about this patch?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America