linux-kernel - Re: [PATCH] leds: netxbig: fix module autoload for OF registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b55c25a7-56d6-d141-f2a9-6faa97a040d0@osg.samsung.com>
Date:   Tue, 29 Nov 2016 12:38:48 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:     linux-kernel@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: netxbig: fix module autoload for OF registration

Hello Jacek,

On 11/29/2016 12:34 PM, Jacek Anaszewski wrote:
> Hi Javier,
> 
> On 11/29/2016 04:00 PM, Javier Martinez Canillas wrote:
>> Hello Jacek,
>>
>> On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
>>> If the driver is built as a module, autoload won't work because the module
>>> alias information is not filled. So user-space can't match the registered
>>> device with the corresponding module.
>>>
>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>>
>>> Before this patch:
>>>
>>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>>> alias:          platform:leds-netxbig
>>>
>>> After this patch:
>>>
>>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>>> alias:          platform:leds-netxbig
>>> alias:          of:N*T*Clacie,netxbig-ledsC*
>>> alias:          of:N*T*Clacie,netxbig-leds
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>>> ---
>>>
>>
>> Any comments about this patch?
> 
> I mistakenly marked it as merged. Sorry about that.
> Applied to the for-next branch of linux-leds.git.
> 

Great, thanks for the information.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America