linux-kernel - Re: [RFC 1/4] mm: Define coherent device memory node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <692074f0-184f-e506-40a1-8fc078d1e706@intel.com>
Date:   Tue, 29 Nov 2016 09:57:26 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Anshuman Khandual <khandual@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     mhocko@...e.com, vbabka@...e.cz, mgorman@...e.de,
        minchan@...nel.org, aneesh.kumar@...ux.vnet.ibm.com,
        bsingharora@...il.com, srikar@...ux.vnet.ibm.com,
        haren@...ux.vnet.ibm.com, jglisse@...hat.com
Subject: Re: [RFC 1/4] mm: Define coherent device memory node

On 11/22/2016 06:19 AM, Anshuman Khandual wrote:
> @@ -393,6 +393,9 @@ enum node_states {
>  	N_MEMORY = N_HIGH_MEMORY,
>  #endif
>  	N_CPU,		/* The node has one or more cpus */
> +#ifdef CONFIG_COHERENT_DEVICE
> +	N_COHERENT_DEVICE,
> +#endif
>  	NR_NODE_STATES
>  };

Don't we really want this to be N_MEMORY_ISOLATED?  Or, better yet,
N_MEMORY_UNISOLATED so that we can just drop the bitmap in for N_MEMORY
and not have to do any bit manipulation operations at runtime.