linux-kernel - Re: [PATCH] drm/vmwgfx: Fix handling of errors returned by 'vmw_cotable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161129171818.GA21736@promb-2n-dhcp150.eng.vmware.com>
Date:   Tue, 29 Nov 2016 09:18:19 -0800
From:   Sinclair Yeh <syeh@...are.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC:     <linux-graphics-maintainer@...are.com>, <thellstrom@...are.com>,
        <airlied@...ux.ie>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] drm/vmwgfx: Fix handling of errors returned by
 'vmw_cotable_alloc()'

Good catch.

Reviewed-by: Sinclair Yeh <syeh@...are.com>

On Tue, Nov 29, 2016 at 07:49:19AM +0100, Christophe JAILLET wrote:
> 'vmw_cotable_alloc()' returns an error pointer on error, not NULL.
> Propagate the error code, instead of returning -ENOMEM unconditionally
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_context.c b/drivers/gpu/drm/vmwgfx/vmwgfx_context.c
> index 443d1ed00de7..d1aee9860033 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_context.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_context.c
> @@ -209,8 +209,8 @@ static int vmw_gb_context_init(struct vmw_private *dev_priv,
>  		for (i = 0; i < SVGA_COTABLE_DX10_MAX; ++i) {
>  			uctx->cotables[i] = vmw_cotable_alloc(dev_priv,
>  							      &uctx->res, i);
> -			if (unlikely(uctx->cotables[i] == NULL)) {
> -				ret = -ENOMEM;
> +			if (unlikely(IS_ERR(uctx->cotables[i]))) {
> +				ret = PTR_ERR(uctx->cotables[i]);
>  				goto out_cotables;
>  			}
>  		}
> -- 
> 2.9.3
>