linux-kernel - Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161130050420.GB27079@localhost.localdomain>
Date:   Tue, 29 Nov 2016 21:04:21 -0800
From:   Eduardo Valentin <edubezval@...il.com>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Caesar Wang <wxt@...k-chips.com>, rui.zhang@...el.com,
        heiko@...ech.de, smbarber@...omium.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error
 messages

Hey,

On Mon, Nov 28, 2016 at 09:47:29PM -0800, Brian Norris wrote:
> Hi,
> 

<cut>

> > > +		       __func__, table.mode);
> > 
> > Given that we are improving messages, would it be more informative to
> > say that you have an invalid table mode?
> 
> I considered the mode and ID listing to go hand in hand, so it was the
> whole table that is wrong. But it is just as well to say the "table
> mode" is wrong.
> 
> Maybe even better: "%s: unknown table mode: %d\n".
> 

Yup, that works for me, even better.

> And I guess same answer for patch 4, where you had the same question.

yes

> 
> Brian
> 
> > > +		return -EINVAL;