lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Nov 2016 08:17:42 +0100 From: Boris Brezillon <boris.brezillon@...e-electrons.com> To: Masahiro Yamada <yamada.masahiro@...ionext.com> Cc: linux-mtd@...ts.infradead.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Marek Vasut <marek.vasut@...il.com>, Brian Norris <computersforpeace@...il.com>, Richard Weinberger <richard@....at>, David Woodhouse <dwmw2@...radead.org>, Cyrille Pitchen <cyrille.pitchen@...el.com> Subject: Re: [PATCH 21/39] mtd: nand: denali: support 64bit capable DMA engine On Wed, 30 Nov 2016 16:11:53 +0900 Masahiro Yamada <yamada.masahiro@...ionext.com> wrote: > Hi Boris, > > 2016-11-28 1:16 GMT+09:00 Boris Brezillon <boris.brezillon@...e-electrons.com>: > > > > If you follow my suggestions of definition function pointers, you'll > > just have to add a function pointer to the denali_caps struct: > > > > void (*setup_dma)(struct denali_nand_info *denali, int op); > > > > > This is possible because both 32B and 64B variants have > the same function prototype. > > > However, I am not keen on doing so for ecc_handle(), > so, at this moment, I am not keen on doing so only for setup_dma() either. > > If I see more cases that fit in callback handler approach, > I will think about switching to it with consistency. > Pretty much all the flags you define in this series could be turned into function pointers. I still think the function pointers approach is more future-proof, but I won't fight on that, so do as you wish.
Powered by blists - more mailing lists