linux-kernel - Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161130090120.GB32672@kroah.com>
Date:   Wed, 30 Nov 2016 10:01:20 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yan Laijun <yan.laijun@...il.com>
Cc:     devel@...verdev.osuosl.org, sergio.paracuellos@...il.com,
        linux-kernel@...r.kernel.org, bhumirks@...il.com
Subject: Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c  Fixed too long code
 line warnings.

On Wed, Nov 30, 2016 at 12:29:13PM +0800, Yan Laijun wrote:
> Fixed checkpatch warning "line over 80 characters" in
> wlan-ng/hfa384x_usb.c file.
> 
> Signed-off-by: Yan Laijun <yan.laijun@...il.com>
> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5f11f6e..3447fc5 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
>  {
>  	struct wlandevice *wlandev = urb->context;
>  	struct hfa384x *hw;
> -	union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> +	union hfa384x_usbin *usbin = NULL;

Why set this to NULL if you then assign it to something else a few lines
later?

thanks,

greg k-h