linux-kernel - RE: [char-msic 1/3] mei: me: disable driver on SPT SPS firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B5433444F@hasmsx108.ger.corp.intel.com>
Date:   Wed, 30 Nov 2016 09:40:37 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>
Subject: RE: [char-msic 1/3] mei: me: disable driver on SPT SPS firmware


> 
> On Tue, Nov 29, 2016 at 09:41:41PM +0000, Winkler, Tomas wrote:
> >
> >
> > >
> > > On Tue, Nov 29, 2016 at 07:21:43PM +0000, Winkler, Tomas wrote:
> > > > >
> > > > > On Tue, Nov 29, 2016 at 02:44:44PM +0200, Tomas Winkler wrote:
> > > > > > commit 8c57cac1457f3125a5d13dc03635c0708c61bff0 upstream
> > > > > >
> > > > > > Sunrise Point PCH with SPS Firmware doesn't expose working MEI
> > > > > > interface, we need to quirk it out.
> > > > > > The SPS Firmware is identifiable only on the first PCI
> > > > > > function of the device.
> > > > > >
> > > > > > Cc: <stable@...r.kernel.org> #4.4
> > > > > > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > > > > ---
> > > > > >  drivers/misc/mei/hw-me.c  | 10 ++++++++--
> > > > > > drivers/misc/mei/pci-me.c
> > > > > > |  4 ++--
> > > > > >  2 files changed, 10 insertions(+), 4 deletions(-)
> > > > >
> > > > > I don't understand what this is for, it's already in the
> > > > > 4.8-stable tree.  And there you said it only needed to go to 4.6
> > > > > and newer, yet you are
> > > saying 4.4 here?
> > > > > What am I supposed to do?
> > > > >
> > > >
> > > > It's needed 4.4, but the original patch does apply cleanly only
> > > > from 4.6 up, so
> > > this is the rebased version over 4.4. Since 4.4 is a long term
> > > kernel this is important.
> > > > I  see from time to time broken patches in stable,  mostly in 3.X
> > > > series, so I
> > > prefer to do the back port myself.
> > >
> > > Ok, but your [char-misc] in the subject confused me.  Please make
> > > this a bit more explicit next time.
> >
> > I see, it's automated in my scripts. Will [char-misc 4.4] or [stable 4.4] works
> for you?
> 
> It's not that automated as it is misspelled in this series :)

Yes I know, the script is a bit dyslectic., AI is going too far :)
> 
> Anyway, stable would make more sense, char-misc 4.4 does not mean
> anything...

Okay, will skip to that, Maybe Documentation/stable_kernel_rules.txt need some updates,
 also not sure you followed the mail thread regarding the git send-email issue 
https://lkml.org/lkml/2016/11/24/836
Your input will be valued. 

Thanks
Tomas