linux-kernel - [PATCH] usb:hub: readibility and consistency in coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3>
Date:   Wed, 30 Nov 2016 11:51:39 +0000
From:   Atul Raj <atul.r@...sung.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        gregkh@...uxfoundation.org 
        <gregkh@...uxfoundation.org>,
        mathias.nyman@...ux.intel.com 
        <mathias.nyman@...ux.intel.com>,
        stern@...land.harvard.edu 
        <stern@...land.harvard.edu>,
        baolu.lu@...ux.intel.com 
        <baolu.lu@...ux.intel.com>,
        oneukum@...e.com <oneukum@...e.com>,
        hansy@...dia.com <hansy@...dia.com>,
        alcooperx@...il.com <alcooperx@...il.com>
Cc:     atulraj.nith@...il.com 
        <atulraj.nith@...il.com>,
        dri-devel@...ts.freedesktop.org 
        <dri-devel@...ts.freedesktop.org>,
        linux-kernel@...r.kernel.org 
        <linux-kernel@...r.kernel.org>,
        Pankaj Singh <pankaj.s4@...sung.com>
Subject: [PATCH] usb:hub: readibility and consistency in coding style

It is suggested to keep braces if there is a comment in if case as
comment also takes a line.
---
 drivers/usb/core/hub.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 82059f26..f43e6302 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -5334,10 +5334,10 @@ static int descriptors_changed(struct usb_device *udev,
        }

        buf = kmalloc(len, GFP_NOIO);
-       if (!buf)
+       if (!buf) {
                /* assume the worst */
                return 1;
-
+       }
        for (index = 0; index < udev->descriptor.bNumConfigurations; index++) {
                old_length = le16_to_cpu(udev->config[index].desc.wTotalLength);
                length = usb_get_descriptor(udev, USB_DT_CONFIG, index, buf,
--
2.10.2.windows.1