linux-kernel - RE: Re: [PATCH] usb:hub: readibility and consistency in coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20161130123521epcms5p3aa0bd43d60fa69c7c7fbc1bbe7fa0099@epcms5p3>
Date:   Wed, 30 Nov 2016 12:35:21 +0000
From:   Atul Raj <atul.r@...sung.com>
To:     gregkh@...uxfoundation.org 
        <gregkh@...uxfoundation.org>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>,
        mathias.nyman@...ux.intel.com 
        <mathias.nyman@...ux.intel.com>,
        stern@...land.harvard.edu 
        <stern@...land.harvard.edu>,
        baolu.lu@...ux.intel.com 
        <baolu.lu@...ux.intel.com>,
        oneukum@...e.com <oneukum@...e.com>,
        hansy@...dia.com <hansy@...dia.com>,
        alcooperx@...il.com <alcooperx@...il.com>,
        atulraj.nith@...il.com 
        <atulraj.nith@...il.com>,
        dri-devel@...ts.freedesktop.org 
        <dri-devel@...ts.freedesktop.org>,
        linux-kernel@...r.kernel.org 
        <linux-kernel@...r.kernel.org>,
        Pankaj Singh <pankaj.s4@...sung.com>
Subject: RE: Re: [PATCH] usb:hub: readibility and consistency in coding style

Hi Greg,

I am so happy to get a mail from you and I am really sorry Greg that I disappointed you.
I will take utmost care in future.
I will send you correct patch in sometime.
for your ques
"Also, why are you including a ton of people who have nothing to do with
usb patches on this one?"

I got the name of people from get_maintainer.pl
from now I will include only you.
is it ok??


one more thing in another mail you replied to me as
On Wed, Nov 30, 2016 at 11:40:28AM +0000, Atul Raj wrote:
>  changes in v2
>         - added braces as suggested.

Why is this here?

> 
>  drivers/usb/core/hub.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

do you disagree with viresh comment of braces???

Thanks for your words.


Your Fan
Atul Raj


>
 > On Wed, Nov 30, 2016 at 11:51:39AM +0000, Atul Raj wrote:
 > > It is suggested to keep braces if there is a comment in if case as
 > > comment also takes a line.
 > > ---
 > >  drivers/usb/core/hub.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
 >
 > Ok, this is getting to be a joke.
 >
 > Take a few days off, relax, then try to send a patch that works to
 > yourself first, and run it through scripts/checkpatch.pl to verify that
 > it really is correct.  Hint, this one isn't at all.
 >
 > Then, maybe you should start doing some work on drivers/staging/ first,
 > which is where new developers should start out to work out all of these
 > issues so you don't bother the other developers who are working on
 > adding new features and fixing bugs.
 >
 > Also, why are you including a ton of people who have nothing to do with
 > usb patches on this one?
 >
 > good luck,
 >
 > greg k-h