linux-kernel - [PATCH] usb: host: replace symbolic permission with octal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Nov 2016 13:49:02 +0000
From:   Amit Kumar Kushwaha <kushwaha.a@...sung.com>
To:     gregkh@...uxfoundation.org 
        <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org 
        <linux-kernel@...r.kernel.org>,
        dri-devel@...ts.freedesktop.org 
        <dri-devel@...ts.freedesktop.org>,
        linux-usb@...r.kernel.org 
        <linux-usb@...r.kernel.org>,
        akkushwaha9896@...il.com 
        <akkushwaha9896@...il.com>
Subject: [PATCH] usb: host: replace symbolic permission with octal

This patch handles warning message for preferring octal
permissions over Symbolic permission for module parameter

Signed-off-by: Amit Kushwaha <kushwaha.a@...sung.com>
---
 drivers/usb/host/xhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 1a4ca02..a953d47 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -40,11 +40,11 @@
 
 /* Some 0.95 hardware can't handle the chain bit on a Link TRB being cleared */
 static int link_quirk;
-module_param(link_quirk, int, S_IRUGO | S_IWUSR);
+module_param(link_quirk, int, 0644);
 MODULE_PARM_DESC(link_quirk, "Don't clear the chain bit on a link TRB");
 
 static unsigned int quirks;
-module_param(quirks, uint, S_IRUGO);
+module_param(quirks, uint, 0444);
 MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default");
 
 /* TODO: copied from ehci-hcd.c - can this be refactored? */
-- 
2.10.2.windows.1