linux-kernel - Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d26f37e6-657f-ff42-2d9d-343fa47c2e5d@ti.com>
Date:   Wed, 30 Nov 2016 11:09:03 -0600
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Murali Karicheri <m-karicheri2@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>
CC:     Sekhar Nori <nsekhar@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP

+ Santosh Shilimkar <santosh.shilimkar@...cle.com>

On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
> The irq_set_affinity_hint() will always fail when !SMP and
> Networking will fail on Keystone 2 devices in this case.
> Hence, fix by ignoring IRQ affinity settings when !SMP.
>
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> ---
>  drivers/soc/ti/knav_qmss_queue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index b73e353..eacad57 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
>
>  		range->num_irqs++;
>
> -		if (oirq.args_count == 3)
> +		if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
>  			range->irqs[i].cpu_map =
>  				(oirq.args[2] & 0x0000ff00) >> 8;
>  	}
>

-- 
regards,
-grygorii