lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Nov 2016 12:30:06 -0600 From: Grygorii Strashko <grygorii.strashko@...com> To: Richard Cochran <richardcochran@...il.com> CC: "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>, Mugunthan V N <mugunthanvnm@...com>, Sekhar Nori <nsekhar@...com>, <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>, <devicetree@...r.kernel.org>, Murali Karicheri <m-karicheri2@...com>, Wingman Kwok <w-kwok2@...com> Subject: Re: [PATCH v2 07/13] net: ethernet: ti: cpts: rework initialization/deinitialization Hi Richard, On 11/29/2016 09:50 AM, Grygorii Strashko wrote: > On 11/29/2016 04:07 AM, Richard Cochran wrote: >> On Mon, Nov 28, 2016 at 05:03:31PM -0600, Grygorii Strashko wrote: >>> +int cpts_register(struct cpts *cpts) >>> { >>> int err, i; >>> >>> - cpts->info = cpts_info; >>> - spin_lock_init(&cpts->lock); >>> - >>> - cpts->cc.read = cpts_systim_read; >>> - cpts->cc.mask = CLOCKSOURCE_MASK(32); >>> - cpts->cc_mult = mult; >>> - cpts->cc.mult = mult; >>> - cpts->cc.shift = shift; >>> - >>> INIT_LIST_HEAD(&cpts->events); >>> INIT_LIST_HEAD(&cpts->pool); >>> for (i = 0; i < CPTS_MAX_EVENTS; i++) >>> list_add(&cpts->pool_data[i].list, &cpts->pool); >>> >>> - cpts_clk_init(dev, cpts); >>> + clk_enable(cpts->refclk); >>> + >>> cpts_write32(cpts, CPTS_EN, control); >>> cpts_write32(cpts, TS_PEND_EN, int_enable); >>> >>> + cpts->cc.mult = cpts->cc_mult; >> >> It is not clear why you set cc.mult in a different place than >> cc.shift. That isn't logical, but maybe later patches make it >> clear... > > cc.mult has to be reloaded to original value each time CPTS is registered(restarted) > as it can be modified by cpts_ptp_adjfreq(). > > While cc.shift is static. > > Will it ok if i will add comment here and re-send series? -- regards, -grygorii
Powered by blists - more mailing lists