linux-kernel - Re: [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k2bklkto.fsf@free-electrons.com>
Date:   Wed, 30 Nov 2016 22:27:47 +0100
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     David Miller <davem@...emloft.net>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        jszhang@...vell.com, arnd@...db.de, jason@...edaemon.net,
        andrew@...n.ch, sebastian.hesselbarth@...il.com,
        thomas.petazzoni@...e-electrons.com,
        linux-arm-kernel@...ts.infradead.org, nadavh@...vell.com,
        mw@...ihalf.com, dima@...vell.com, yelena@...vell.com
Subject: Re: [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address

Hi David,
 
 On mer., nov. 30 2016, David Miller <davem@...emloft.net> wrote:

> From: Gregory CLEMENT <gregory.clement@...e-electrons.com>
> Date: Tue, 29 Nov 2016 15:55:21 +0100
>
>> +	/* Virtual address of the RX buffer */
>> +	void  **buf_virt_addr;
>> +
>>  	/* Virtual address of the RX DMA descriptors array */
>>  	struct mvneta_rx_desc *descs;
>>  
>  ...
>> +		data = (unsigned char *)rxq->buf_virt_addr[index];
>
> This cast is unnecessary, please remove it.

OK I am doing it now.

Thanks,

Gregory


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com