linux-kernel - [PATCH 1/1] bluetooth: propagate the error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu,  1 Dec 2016 14:23:29 +0800
From:   Pan Bian <bianpan2016@....com>
To:     Marcel Holtmann <marcel@...tmann.org>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>
Cc:     linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pan Bian <bianpan2016@....com>
Subject: [PATCH 1/1] bluetooth: propagate the error code

Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188551. A negative
return value means there are errors, while 0 indicates success. However,
in function bpa10x_send_frame(), it returns 0 no matter whether
usb_submit_urb() returns a negative value. As a result, the caller of
bpa10x_send_frame() may not detect the submission error. In this patch,
use "return err;" at the end to propagate the error.

Signed-off-by: Pan Bian <bianpan2016@....com>
---
 drivers/bluetooth/bpa10x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c
index a9932fe..d2bebee 100644
--- a/drivers/bluetooth/bpa10x.c
+++ b/drivers/bluetooth/bpa10x.c
@@ -355,7 +355,7 @@ static int bpa10x_send_frame(struct hci_dev *hdev, struct sk_buff *skb)

 	usb_free_urb(urb);

-	return 0;
+	return err;
 }

 static int bpa10x_set_diag(struct hci_dev *hdev, bool enable)
-- 
1.9.1