linux-kernel - Re: [RESEND PATCH 11/11] tools/power turbostat: enable turbostat to support Knights Mill (KNM)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1480591045.4677.45.camel@intel.com>
Date:   Thu, 1 Dec 2016 11:17:56 +0000
From:   "Luc, Piotr" <Piotr.Luc@...el.com>
To:     "lenb@...nel.org" <lenb@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "dougthompson@...ssion.com" <dougthompson@...ssion.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "srinivas.pandruvada@...ux.intel.com" 
        <srinivas.pandruvada@...ux.intel.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: Re: [RESEND PATCH 11/11] tools/power turbostat: enable turbostat to
 support Knights Mill (KNM)

On Thu, 2016-12-01 at 01:47 -0500, Len Brown wrote:
> Piotr,
> Thanks for sending the patch, I've made this change to my turbostat
> branch for 4.10.
> 
> I did not apply your patch directly because for some reason it didn't
> appear in patchwork for linux-pm,
> only for lkml, which I do not review.

The missing from linux-pm was my mistake due to lack of experience and
perspicacity; I did not add the linux-pm list to cc because I could not
find an entry for turbostat on MAINTAINERS file. Probably, it is
mentioned implicitly but I did not come across it.
> 
> Also, your patch depended on your style update patch to use the model
> # macros.
> Unfortunately what you did not know was that I'd already applied a
> slightly different style update patch.
> (and it was my fault that I did not push it upstream before my summer
> sabbatical, sorry)

NP, this was an easy change made automatically by my script.

> 
> In general, though, a good strategy when mixing style and
> functionality patches
> is to do the functionality first.  The reason is both that style
> patches tend to conflict more,
> and you don't want them to hold up the functionality.
> Also, if your functionality patch does not depend on style,
> it is easier to backport to distros who avoid style updates.

Thanks for the tip.
However, in this case, I got comments to use the macros instead raw
numbers in my patch and remove unnecessary comments. It caused that the
style patch came first.

Thanks
Piotr