[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161201010701.GC12039@jagdpanzerIV>
Date: Thu, 1 Dec 2016 10:07:01 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Jan Kara <jack@...e.cz>, Tejun Heo <tj@...nel.org>,
Calvin Owens <calvinowens@...com>,
Thomas Gleixner <tglx@...utronix.de>,
Mel Gorman <mgorman@...hsingularity.net>,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Laura Abbott <labbott@...hat.com>,
Andy Lutomirski <luto@...nel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Kees Cook <keescook@...omium.org>,
linux-kernel@...r.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [RFC][PATCHv4 2/6] printk: rename nmi.c and exported api
On (11/24/16 17:35), Petr Mladek wrote:
[..]
> > #ifdef CONFIG_PRINTK_NMI
> > -extern void printk_nmi_init(void);
> > -extern void printk_nmi_enter(void);
> > -extern void printk_nmi_exit(void);
> > -extern void printk_nmi_flush(void);
> > -extern void printk_nmi_flush_on_panic(void);
> > +extern void printk_safe_init(void);
> > +extern void printk_safe_nmi_enter(void);
> > +extern void printk_safe_nmi_exit(void);
>
> I would personally keep the short names pritnk_nmi_enter() and
> printk_nmi_exit(). These are the only functions that will stay
> in this CONFIG_PRINT_NMI section. The others are generic and
> will be moved to the generic section in the next patch.
I'd probably prefer all printk_safe functions to be printk_safe
prefixed, just to show the fact that those are printk_safe
functions (IOW, indirect output to a per-CPU buffer and flush
it to logbuf later).
> Well, it is just a cosmetic problem and a personal opinion.
> The patch makes sense and looks fine:
>
> Reviewed-by: Petr Mladek <pmladek@...adek@...e.com>
thanks.
-ss
Powered by blists - more mailing lists