linux-kernel - Re: [PATCH 1/1] block: mtip32xx: set error code on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae325a8d-cd91-b8d1-17f5-85613e9a4b10@fb.com>
Date:   Thu, 1 Dec 2016 08:01:58 -0700
From:   Jens Axboe <axboe@...com>
To:     Pan Bian <bianpan2016@....com>,
        Asai Thambi SP <asamymuthupa@...ron.com>,
        Selvan Mani <smani@...ron.com>,
        Rajesh Kumar Sambandam <rsambandam@...ron.com>,
        Vignesh Gunasekaran <vgunasekaran@...ron.com>,
        Baoyou Xie <baoyou.xie@...aro.org>,
        Keith Busch <keith.busch@...el.com>,
        "Mike Christie" <mchristi@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] block: mtip32xx: set error code on failure

On 11/30/2016 07:10 PM, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188531. In function
> mtip_block_initialize(), variable rv takes the return value, and its
> value should be negative on errors. rv is initialized as 0 and is not
> reset when the call to ida_pre_get() fails. So 0 may be returned.
> The return value 0 indicates that there is no error, which may be
> inconsistent with the execution status. This patch fixes the bug by
> explicitly assigning -ENOMEM to rv on the branch that ida_pre_get()
> fails.

Thanks, applied for 4.10.

-- 
Jens Axboe