linux-kernel - Re: [PATCH v2] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87shq7d3zq.fsf@vitty.brq.redhat.com>
Date:   Thu, 01 Dec 2016 17:10:49 +0100
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     x86@...nel.org
Cc:     devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v2] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic

Vitaly Kuznetsov <vkuznets@...hat.com> writes:

[snip]

>  static void __init ms_hyperv_init_platform(void)
>  {
>  	/*
> @@ -183,6 +204,9 @@ static void __init ms_hyperv_init_platform(void)
>  		pr_info("HyperV: LAPIC Timer Frequency: %#x\n",
>  			lapic_timer_frequency);
>  	}
> +
> +	register_nmi_handler(NMI_LOCAL, hv_nmi_unknown, NMI_FLAG_FIRST,
> +			     "hv_nmi_unknown");

This should probably be NMI_UNKNOWN instead of NMI_LOCAL. While it works
regardless and we don't have other NMIs on Hyper-V VMs (or do we?) I
think it would be better to do v3.

Sorry for the inconvenience.

-- 
  Vitaly