linux-kernel - Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5684f31-f1e4-75fd-852b-fd62f0940eef@st.com>
Date:   Thu, 1 Dec 2016 18:21:05 +0100
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     David Miller <davem@...emloft.net>, <niklas.cassel@...s.com>
CC:     <peppe.cavallaro@...com>, <niklass@...s.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized
 with multiple TX queues

Hi David and Niklas,

On 11/28/2016 05:29 PM, David Miller wrote:
> From: Niklas Cassel <niklas.cassel@...s.com>
> Date: Thu, 24 Nov 2016 15:36:33 +0100
>
>> From: Niklas Cassel <niklas.cassel@...s.com>
>>
>> The dwmac4 IP can synthesized with 1-8 number of tx queues.
>> On an IP synthesized with DWC_EQOS_NUM_TXQ > 1, all txqueues are disabled
>> by default. For these IPs, the bitfield TXQEN is R/W.
>>
>> Always enable tx queue 0. The write will have no effect on IPs synthesized
>> with DWC_EQOS_NUM_TXQ == 1.
>>
>> The driver does still not utilize more than one tx queue in the IP.
>>
>> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>
>
> Alexandre, we are still waiting for your implicit/explicit ACK on this
> change.

Yes you could add my Acked-by but it is already merged. My fault.
Sorry for my late answer :(

>
> Thank you.
>