linux-kernel - Re: [PATCH] HID: intel_ish-hid: use %pUL for uuid formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1480636273.2442.0.camel@linux.intel.com>
Date:   Thu, 01 Dec 2016 15:51:13 -0800
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: intel_ish-hid: use %pUL for uuid formatting

On Thu, 2016-12-01 at 15:21 +0100, Benjamin Tissoires wrote:
> On Nov 30 2016 or thereabouts, Rasmus Villemoes wrote:
> > 
> > We have the %pU printf extension for doing exactly this. Saves some
> > .text, and is likely also a little faster.
> > 
> > Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> 
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> 
> > 
> > ---
> >  drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> > 
> > diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> > b/drivers/hid/intel-ish-hid/ishtp/bus.c
> > index 256521509d20..f4cbc744e657 100644
> > --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> > +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> > @@ -585,14 +585,7 @@ int ishtp_bus_new_client(struct ishtp_device
> > *dev)
> >  	 */
> >  	i = dev->fw_client_presentation_num - 1;
> >  	device_uuid = dev->fw_clients[i].props.protocol_name;
> > -	dev_name = kasprintf(GFP_KERNEL,
> > -		"{%02X%02X%02X%02X-%02X%02X-%02X%02X-%02X%02X-
> > %02X%02X%02X%02X%02X%02X}",
> > -		device_uuid.b[3], device_uuid.b[2],
> > device_uuid.b[1],
> > -		device_uuid.b[0], device_uuid.b[5],
> > device_uuid.b[4],
> > -		device_uuid.b[7], device_uuid.b[6],
> > device_uuid.b[8],
> > -		device_uuid.b[9], device_uuid.b[10],
> > device_uuid.b[11],
> > -		device_uuid.b[12], device_uuid.b[13],
> > device_uuid.b[14],
> > -		device_uuid.b[15]);
> > +	dev_name = kasprintf(GFP_KERNEL, "{%pUL}", device_uuid.b);
> >  	if (!dev_name)
> >  		return	-ENOMEM;
> >  
> > -- 
> > 2.1.4
> >