linux-kernel - Re: [PATCH 1/1] dma: ioat: set error code on failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161202103225.GM6408@localhost>
Date:   Fri, 2 Dec 2016 16:02:25 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Pan Bian <bianpan2016@....com>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Julia Lawall <Julia.Lawall@...6.fr>, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] dma: ioat: set error code on failures

On Thu, Dec 01, 2016 at 03:10:12PM +0800, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188591. In function
> ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
> value of return variable err is 0 (indicates no error). As a result, the
> return value may be inconsistent with the execution status. This patch
> fixes the bug by assigning -ENOMEM to err on the error path.

Please describe the fix you are doing. For Bugzilla you can use Fixes tag

Also add the correct subsystem tag, so the changelog can look like:

dmaengine: ioat: set error code on failures

In ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
value of return variable err is 0 ...

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188591
Fixes: Commit you fixes

..

So please update the changelog and resend with Acks collected

-- 
~Vinod