[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1ab20bad-e044-8bba-cbb2-21dfd799b719@gmail.com>
Date: Fri, 2 Dec 2016 13:46:47 +0100
From: Marek Vasut <marek.vasut@...il.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc: Cyrille Pitchen <cyrille.pitchen@...el.com>,
David Woodhouse <dwmw2@...radead.org>,
Brian Norris <computersforpeace@...il.com>,
Boris Brezillon <boris.brezillon@...e-electrons.com>,
Richard Weinberger <richard@....at>,
"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8] mtd: spi-nor: Add support for S3AN spi-nor devices
On 12/02/2016 11:52 AM, Ricardo Ribalda Delgado wrote:
> Hi Marek
Hi,
> On Thu, Dec 1, 2016 at 7:11 PM, Marek Vasut <marek.vasut@...il.com> wrote:
>> On 12/01/2016 06:52 PM, Ricardo Ribalda Delgado wrote:
>>> Hi Marek
>>
>> Hi,
>>
>>> Thanks for your review
>>>
>>> On Thu, Dec 1, 2016 at 5:05 PM, Marek Vasut <marek.vasut@...il.com> wrote:
>>>>
>>>> On 11/24/2016 05:56 PM, Ricardo Ribalda Delgado wrote:
>>>
>>>>> +#define SPI_S3AN BIT(10) /*
>>>>> + * Xilinx Spartan 3AN In-System Flash
>>>>> + * (MFR cannot be used for probing
>>>>> + * because it has the same value as
>>>>> + * ATMEL flashes)
>>>>> + */
>>>>
>>>> I have possibly off-topic question. Altera has something very similar --
>>>> EPCS/EPCQ flash which cannot be detected using standard READID .
>>>> Would this patch help with supporting those degenerate flashes too?
>>>>
>>>>> };
>>>>>
>>>
>>> I dont know, but I love the term degenerated flash, please let me use it :)
>>
>> Hehe. It'd be great to know whether we don't have a possibility for a
>> generic usecase here. Can you briefly check that ?
>
> I have taken a brief look to
> https://www.altera.com/content/dam/altera-www/global/en_US/pdfs/literature/hb/cfg/cfg_cf52012.pdf
>
> and they seem different enough to not reuse the flag :(.
OK, fine, thanks for checking.
>>> I guess they are using some bits reserved to ECC for data and that way
>>> you can squeeze some bits for user data.
>>
>> OK, comment could help clarify this, so please add one.
>
> Will send a v9
Thanks!
--
Best regards,
Marek Vasut
Powered by blists - more mailing lists