linux-kernel - Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <877f7ie3qg.fsf@linux.vnet.ibm.com>
Date:   Fri, 02 Dec 2016 21:13:19 +0530
From:   "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:     Dave Hansen <dave@...1.net>, linux-kernel@...r.kernel.org
Cc:     Dave Hansen <dave@...1.net>, hch@....de, akpm@...ux-foundation.org,
        dan.j.williams@...el.com, khandual@...ux.vnet.ibm.com,
        vbabka@...e.cz, linux-mm@...ck.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v3)

Dave Hansen <dave@...1.net> writes:

> Andrew, you can drop proc-mm-export-pte-sizes-directly-in-smaps-v2.patch,
> and replace it with this.
>
.....

> diff -puN mm/hugetlb.c~smaps-pte-sizes mm/hugetlb.c
> --- a/mm/hugetlb.c~smaps-pte-sizes	2016-11-28 14:21:37.555519365 -0800
> +++ b/mm/hugetlb.c	2016-11-28 14:28:49.186234688 -0800
> @@ -2763,6 +2763,17 @@ void __init hugetlb_add_hstate(unsigned
>  					huge_page_size(h)/1024);
>  
>  	parsed_hstate = h;
> +
> +	/*
> +	 * PGD_SIZE isn't widely made available by architecures,
> +	 * so use PUD_SIZE*PTRS_PER_PUD as a substitute.
> +	 *
> +	 * Check for sizes that might be mapped by a PGD.  There
> +	 * are none of these known today, but be on the lookout.
> +	 * If this trips, we will need to update the mss->rss_*
> +	 * code in fs/proc/task_mmu.c.
> +	 */
> +	WARN_ON_ONCE((PAGE_SIZE << order) >= PUD_SIZE * PTRS_PER_PUD);
>  }

This will trip for ppc64 16GB hugepage.

For ppc64 we have the 16G at pgd level.

-aneesh