linux-kernel - Re: [PATCH 1/8 linux-next] libnvdimm, namespace: update message level on smaller reservations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4jWW+-uH-TE1wbe9eFdb0TYmubLvG6ONTKETgNZqoK+KA@mail.gmail.com>
Date:   Fri, 2 Dec 2016 11:45:27 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Fabian Frederick <fabf@...net.be>
Cc:     "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/8 linux-next] libnvdimm, namespace: update message level
 on smaller reservations

On Fri, Dec 2, 2016 at 11:19 AM, Fabian Frederick <fabf@...net.be> wrote:
> kernel command lines like memmap=1M!512M gave no pmem outputs
> without debugging.
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/nvdimm/namespace_devs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
> index abe5c6b..b00045b 100644
> --- a/drivers/nvdimm/namespace_devs.c
> +++ b/drivers/nvdimm/namespace_devs.c
> @@ -1532,8 +1532,8 @@ struct nd_namespace_common *nvdimm_namespace_common_probe(struct device *dev)
>
>         size = nvdimm_namespace_capacity(ndns);
>         if (size < ND_MIN_NAMESPACE_SIZE) {
> -               dev_dbg(&ndns->dev, "%pa, too small must be at least %#x\n",
> -                               &size, ND_MIN_NAMESPACE_SIZE);
> +               dev_warn(&ndns->dev, "%pa, too small must be at least %#x\n",
> +                        &size, ND_MIN_NAMESPACE_SIZE);

This is too noisy as it will fire every time a new namespace is
created since they always start out zero-sized.  I'd recommend booting
with libnvdimm.dyndbg on the kernel command or something similar.