linux-kernel - Re: [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4hLrOVfGiZ5Y1QVLY2rkTHcGQqF1n4V5wqvKnE6qghueA@mail.gmail.com>
Date:   Fri, 2 Dec 2016 12:53:34 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Fabian Frederick <fabf@...net.be>
Cc:     "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to
 persistence warning

On Fri, Dec 2, 2016 at 11:20 AM, Fabian Frederick <fabf@...net.be> wrote:
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/nvdimm/pmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 2461843..822a712 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -267,7 +267,7 @@ static int pmem_attach_disk(struct device *dev,
>         pmem->phys_addr = res->start;
>         pmem->size = resource_size(res);
>         if (nvdimm_has_flush(nd_region) < 0)
> -               dev_warn(dev, "unable to guarantee persistence of writes\n");
> +               dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");

I'll pass on this one. Another reason could be that the flushing
capability is present but disabled.  Just seeing it's not guaranteed
is sufficient.