linux-kernel - Re: Odd build breakage in 4.9-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6276dd2d-b2da-67a5-96b2-0a1b5d1be8a2@redhat.com>
Date:   Fri, 2 Dec 2016 17:41:33 -0500
From:   Jarod Wilson <jarod@...hat.com>
To:     Nicolas Pitre <nicolas.pitre@...aro.org>,
        Paul Bolle <pebolle@...cali.nl>
Cc:     Tony Luck <tony.luck@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Prarit Bhargava <prarit@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: Odd build breakage in 4.9-rc7

On 2016-12-02 3:11 PM, Nicolas Pitre wrote:
> On Thu, 1 Dec 2016, Paul Bolle wrote:
>
>> On Thu, 2016-12-01 at 12:42 -0500, Nicolas Pitre wrote:
>>> OK I understand what the problem is.  However most of those hunks below
>>> are definitely wrong. ;-)
>>
>> Probably. By now I've narrowed it down to just these two hunks:
>
> And they're both wrong. ;-) There is no relation between MODVERSIONS and
> TRIM_UNUSED_KSYMS.
>
>>> I'm trying to determine the best way to fix it. Stay tuned.
>>
>> Will do. I'm curious to see what a proper fix might look like.
>
> Here it is:
>
> ----- >8
> Subject: kbuild: fix building bzImage with CONFIG_TRIM_UNUSED_KSYMS enabled
>
> When building a specific target such as bzImage, modules aren't normally
> built. However if CONFIG_TRIM_UNUSED_KSYMS is enabled, no built modules
> means none of the exported symbols are used and therefore they will all
> be trimmed away from the final kernel. A subsequent "make modules" will
> fail because modpost cannot find the needed symbols for those modules in
> the kernel binary.
>
> Let's make sure modules are also built whenever CONFIG_TRIM_UNUSED_KSYMS
> is enabled and that the kernel binary is properly rebuilt accordingly.

For my previously failing case, things behave again with this patch. 
Thanks much!

Tested-by: Jarod Wilson <jarod@...hat.com>

-- 
Jarod Wilson
jarod@...hat.com