linux-kernel - [PATCH 1/1] scsi: csiostor: fix improper return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1480761257-4667-1-git-send-email-bianpan2016@163.com>
Date:   Sat,  3 Dec 2016 18:34:17 +0800
From:   Pan Bian <bianpan2016@....com>
To:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Pan Bian <bianpan2016@....com>
Subject: [PATCH 1/1] scsi: csiostor: fix improper return value

Function csio_hw_flash_erase_sectors() will always return 0, even on
failures. Thus, its callers will not detect the errors, and may produce
unexpected behavior. To avoid bugs, this patch replaces "return 0;" with
"return ret;".

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188681

Signed-off-by: Pan Bian <bianpan2016@....com>
---
 drivers/scsi/csiostor/csio_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
index 622bdab..8970df2 100644
--- a/drivers/scsi/csiostor/csio_hw.c
+++ b/drivers/scsi/csiostor/csio_hw.c
@@ -613,7 +613,7 @@ struct t4_vpd_hdr {
 		csio_err(hw, "erase of flash sector %d failed, error %d\n",
 			 start, ret);
 	csio_wr_reg32(hw, 0, SF_OP_A);    /* unlock SF */
-	return 0;
+	return ret;
 }
 
 static void
-- 
1.9.1