linux-kernel - [PATCH 1/1] xen: xenbus: set error code on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1480762166-4883-1-git-send-email-bianpan2016@163.com>
Date:   Sat,  3 Dec 2016 18:49:26 +0800
From:   Pan Bian <bianpan2016@....com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        David Vrabel <david.vrabel@...rix.com>,
        Juergen Gross <jgross@...e.com>, xen-devel@...ts.xenproject.org
Cc:     linux-kernel@...r.kernel.org, Pan Bian <bianpan2016@....com>
Subject: [PATCH 1/1] xen: xenbus: set error code on failure

In function xenstored_local_init(), the value of return variable err
should be negative on errors. But the value of err keeps 0 even if the 
call to get_zeroed_page() returns a NULL pointer. This patch assigns 
"-ENOMEM" to err on the error branch.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188721

Signed-off-by: Pan Bian <bianpan2016@....com>
---
 drivers/xen/xenbus/xenbus_probe.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
index 33a31cf..f87d047 100644
--- a/drivers/xen/xenbus/xenbus_probe.c
+++ b/drivers/xen/xenbus/xenbus_probe.c
@@ -708,8 +708,10 @@ static int __init xenstored_local_init(void)
 
 	/* Allocate Xenstore page */
 	page = get_zeroed_page(GFP_KERNEL);
-	if (!page)
+	if (!page) {
+		err = -ENOMEM;
 		goto out_err;
+	}
 
 	xen_store_gfn = xen_start_info->store_mfn = virt_to_gfn((void *)page);
 
-- 
1.9.1