linux-kernel - Re: [PATCH] iio: 104-quad-8: Fix index control configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <784965ac-6181-d64e-a44f-b06f2e9510fa@kernel.org>
Date:   Sat, 3 Dec 2016 10:02:19 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     William Breathitt Gray <vilhelm.gray@...il.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: 104-quad-8: Fix index control configuration

On 28/11/16 21:22, William Breathitt Gray wrote:
> The LS7266R1 requires bits 5 & 6 to be high in order to select the Index
> Control Register. This patch fixes a typo that incorrectly selects the
> Input/Output Control Register where the Index Control Register was
> desired.
> 
> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
Applied to the fixes-togreg-post-rc1 branch and marked for stable
(though that is probably irrelevant given this didn't apply to my fixes-togreg tree.

Jonathan
> ---
>  drivers/iio/counter/104-quad-8.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
> index 2d2ee35..c0a69d7 100644
> --- a/drivers/iio/counter/104-quad-8.c
> +++ b/drivers/iio/counter/104-quad-8.c
> @@ -362,7 +362,7 @@ static int quad8_set_synchronous_mode(struct iio_dev *indio_dev,
>  	priv->synchronous_mode[chan->channel] = synchronous_mode;
>  
>  	/* Load Index Control configuration to Index Control Register */
> -	outb(0x40 | idr_cfg, base_offset);
> +	outb(0x60 | idr_cfg, base_offset);
>  
>  	return 0;
>  }
> @@ -444,7 +444,7 @@ static int quad8_set_index_polarity(struct iio_dev *indio_dev,
>  	priv->index_polarity[chan->channel] = index_polarity;
>  
>  	/* Load Index Control configuration to Index Control Register */
> -	outb(0x40 | idr_cfg, base_offset);
> +	outb(0x60 | idr_cfg, base_offset);
>  
>  	return 0;
>  }
>