linux-kernel - Re: [PATCH] iio: 104-quad-8: Fix active level mismatch for the preset enable option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea6bbee3-6770-ea87-1158-2a7d6936a083@kernel.org>
Date:   Sat, 3 Dec 2016 10:08:38 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     William Breathitt Gray <vilhelm.gray@...il.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: 104-quad-8: Fix active level mismatch for the preset
 enable option

On 29/11/16 15:51, William Breathitt Gray wrote:
> The set_to_preset_on_index sysfs attribute provides a boolean
> configuration option to enable a preset operation on the respective
> channel's counter when Index occurs. However, the corresponding
> configuration bit on the Input/Output Control register must be set low
> to enable the preset operation.
> 
> This patch inverts the internal driver boolean logic exposed via the
> set_to_preset_on_index attribute in order to correctly configure the
> device which expects an active low bit.
> 
> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
Applied to the fixes-togreg-post-rc1 branch and marked for stable.

Thanks,

Jonathan
> ---
>  drivers/iio/counter/104-quad-8.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
> index 2d2ee35..9847221 100644
> --- a/drivers/iio/counter/104-quad-8.c
> +++ b/drivers/iio/counter/104-quad-8.c
> @@ -233,7 +233,7 @@ static ssize_t quad8_read_set_to_preset_on_index(struct iio_dev *indio_dev,
>  	const struct quad8_iio *const priv = iio_priv(indio_dev);
>  
>  	return snprintf(buf, PAGE_SIZE, "%u\n",
> -		priv->preset_enable[chan->channel]);
> +		!priv->preset_enable[chan->channel]);
>  }
>  
>  static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
> @@ -250,6 +250,9 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
>  	if (ret)
>  		return ret;
>  
> +	/* Preset enable is active low in Input/Output Control register */
> +	preset_enable = !preset_enable;
> +
>  	priv->preset_enable[chan->channel] = preset_enable;
>  
>  	ior_cfg = priv->ab_enable[chan->channel] |
>