linux-kernel - Re: [PATCH] blk-stat: fix a typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f00d75fa-d76e-50e1-2182-38de2731f2d1@fb.com>
Date:   Fri, 2 Dec 2016 20:19:39 -0700
From:   Jens Axboe <axboe@...com>
To:     Shaohua Li <shli@...com>, <linux-kernel@...r.kernel.org>
CC:     <Kernel-team@...com>
Subject: Re: [PATCH] blk-stat: fix a typo

On 12/02/2016 08:16 PM, Jens Axboe wrote:
> On 12/02/2016 06:13 PM, Shaohua Li wrote:
>> Signed-off-by: Shaohua Li <shli@...com>
>> ---
>>  block/blk-stat.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/blk-stat.c b/block/blk-stat.c
>> index 688c958..4d01185 100644
>> --- a/block/blk-stat.c
>> +++ b/block/blk-stat.c
>> @@ -12,7 +12,7 @@
>>  static void blk_stat_flush_batch(struct blk_rq_stat *stat)
>>  {
>>  	const s32 nr_batch = READ_ONCE(stat->nr_batch);
>> -	const s32 nr_samples = READ_ONCE(stat->nr_batch);
>> +	const s32 nr_samples = READ_ONCE(stat->nr_samples);
>>  
>>  	if (!nr_batch)
>>  		return;
>>
> 
> Gah, that sucks. Thanks, added for 4.10.

BTW, this was added right before inclusion, all the previously posted
versions were not broken in this way. So thanks for spotting this!

-- 
Jens Axboe