lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sat, 3 Dec 2016 18:00:13 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     Kalle Valo <kvalo@...rom.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org
Subject: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6:
 error: redefinition of 'brcmf_debugfs_init'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3c49de52d5647cda8b42c4255cf8a29d1e22eff5
commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move under broadcom vendor directory
date:   1 year, 1 month ago
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All error/warnings (new ones prefixed by >>):

>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'
    void brcmf_debugfs_init(void)
         ^
   In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
                    from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:118:20: note: previous definition of 'brcmf_debugfs_init' was here
    static inline void brcmf_debugfs_init(void)
                       ^
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:65:6: error: redefinition of 'brcmf_debugfs_exit'
    void brcmf_debugfs_exit(void)
         ^
   In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
                    from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:121:20: note: previous definition of 'brcmf_debugfs_exit' was here
    static inline void brcmf_debugfs_exit(void)
                       ^
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:74:5: error: redefinition of 'brcmf_debug_attach'
    int brcmf_debug_attach(struct brcmf_pub *drvr)
        ^
   In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
                    from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:124:19: note: previous definition of 'brcmf_debug_attach' was here
    static inline int brcmf_debug_attach(struct brcmf_pub *drvr)
                      ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debug_attach':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:81:6: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
     drvr->dbgfs_dir = debugfs_create_dir(dev_name(dev), root_folder);
         ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:82:17: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
     if (IS_ERR(drvr->dbgfs_dir))
                    ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:83:22: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
      return PTR_ERR(drvr->dbgfs_dir);
                         ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: At top level:
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:90:6: error: redefinition of 'brcmf_debug_detach'
    void brcmf_debug_detach(struct brcmf_pub *drvr)
         ^
   In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
                    from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:128:20: note: previous definition of 'brcmf_debug_detach' was here
    static inline void brcmf_debug_detach(struct brcmf_pub *drvr)
                       ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debug_detach':
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:94:26: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
     if (!IS_ERR_OR_NULL(drvr->dbgfs_dir))
                             ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:95:32: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
      debugfs_remove_recursive(drvr->dbgfs_dir);
                                   ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debugfs_get_devdir':
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:100:13: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
     return drvr->dbgfs_dir;
                ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: At top level:
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:103:5: error: redefinition of 'brcmf_debugfs_add_entry'
    int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
        ^
   In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
                    from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:132:5: note: previous definition of 'brcmf_debugfs_add_entry' was here
    int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
        ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debugfs_add_entry':
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:109:10: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
         drvr->dbgfs_dir, read_fn);
             ^
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debugfs_get_devdir':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:101:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +/brcmf_debugfs_init +58 drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c

80969836 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   18  #include <linux/module.h>
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   19  #include <linux/devcoredump.h>
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   20  
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   21  #include <brcmu_wifi.h>
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   22  #include <brcmu_utils.h>
122d3d04 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Hante Meuleman   2014-10-28   23  #include "core.h"
d14f78b9 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Hante Meuleman   2014-10-28  @24  #include "bus.h"
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   25  #include "fweh.h"
a8e8ed34 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Hante Meuleman   2014-10-28   26  #include "debug.h"
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   27  
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   28  static struct dentry *root_folder;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   29  
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   30  static int brcmf_debug_create_memdump(struct brcmf_bus *bus, const void *data,
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   31  				      size_t len)
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   32  {
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   33  	void *dump;
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   34  	size_t ramsize;
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   35  
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   36  	ramsize = brcmf_bus_get_ramsize(bus);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   37  	if (ramsize) {
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   38  		dump = vzalloc(len + ramsize);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   39  		if (!dump)
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   40  			return -ENOMEM;
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   41  		memcpy(dump, data, len);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   42  		brcmf_bus_get_memdump(bus, dump + len, ramsize);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   43  		dev_coredumpv(bus->dev, dump, len + ramsize, GFP_KERNEL);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   44  	}
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   45  	return 0;
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   46  }
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   47  
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   48  static int brcmf_debug_psm_watchdog_notify(struct brcmf_if *ifp,
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   49  					   const struct brcmf_event_msg *evtmsg,
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   50  					   void *data)
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   51  {
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   52  	brcmf_dbg(TRACE, "enter: idx=%d\n", ifp->bssidx);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   53  
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   54  	return brcmf_debug_create_memdump(ifp->drvr->bus_if, data,
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   55  					  evtmsg->datalen);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   56  }
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   57  
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09  @58  void brcmf_debugfs_init(void)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   59  {
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   60  	root_folder = debugfs_create_dir(KBUILD_MODNAME, NULL);
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   61  	if (IS_ERR(root_folder))
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   62  		root_folder = NULL;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   63  }
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   64  
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09  @65  void brcmf_debugfs_exit(void)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   66  {
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   67  	if (!root_folder)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   68  		return;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   69  
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   70  	debugfs_remove_recursive(root_folder);
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   71  	root_folder = NULL;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   72  }
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   73  
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08  @74  int brcmf_debug_attach(struct brcmf_pub *drvr)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   75  {
d9cb2596 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-12-05   76  	struct device *dev = drvr->bus_if->dev;
d9cb2596 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-12-05   77  
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   78  	if (!root_folder)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   79  		return -ENODEV;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   80  
d9cb2596 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-12-05  @81  	drvr->dbgfs_dir = debugfs_create_dir(dev_name(dev), root_folder);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08  @82  	if (IS_ERR(drvr->dbgfs_dir))
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   83  		return PTR_ERR(drvr->dbgfs_dir);
82d957e0 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2014-07-12   84  
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   85  
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   86  	return brcmf_fweh_register(drvr, BRCMF_E_PSM_WATCHDOG,
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   87  				   brcmf_debug_psm_watchdog_notify);
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   88  }
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   89  
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08  @90  void brcmf_debug_detach(struct brcmf_pub *drvr)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   91  {
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   92  	brcmf_fweh_unregister(drvr, BRCMF_E_PSM_WATCHDOG);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-10-08   93  
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   94  	if (!IS_ERR_OR_NULL(drvr->dbgfs_dir))
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09  @95  		debugfs_remove_recursive(drvr->dbgfs_dir);
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   96  }
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   97  
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   98  struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09   99  {
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09  100  	return drvr->dbgfs_dir;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 @101  }
80969836 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09  102  
82d957e0 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2014-07-12 @103  int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
82d957e0 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2014-07-12  104  			    int (*read_fn)(struct seq_file *seq, void *data))
80969836 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09  105  {
5b18ffb2 drivers/net/wireless/brcm80211/brcmfmac/debug.c   Arend van Spriel 2015-06-08  106  	struct dentry *e;

:::::: The code at line 58 was first introduced by commit
:::::: d319a7cfd9d80a2e2359e978ba88991531312ee6 brcmfmac: add debugfs helper functions

:::::: TO: Arend van Spriel <arend@...adcom.com>
:::::: CC: John W. Linville <linville@...driver.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (42658 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ