linux-kernel - [PATCH] staging: greybus: Fix macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1480759879-9646-1-git-send-email-cvs@nvidia.com>
Date:   Sat,  3 Dec 2016 15:41:19 +0530
From:   Chinmay VS <cvs268@...il.com>
To:     gregkh@...uxfoundation.org, elder@...nel.org, johan@...nel.org,
        pure.logic@...us-software.ie
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        ChinmayVS <cvs268@...il.com>
Subject: [PATCH] staging: greybus: Fix macro definition

From: ChinmayVS <cvs268@...il.com>

Macros with multiple statements should be enclosed in a do - while loop

Signed-off-by: ChinmayVS <cvs268@...il.com>
---
 drivers/staging/greybus/loopback.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 7882306..39f0a25 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -177,9 +177,11 @@ static ssize_t name##_avg_show(struct device *dev,		\
 static DEVICE_ATTR_RO(name##_avg)
 
 #define gb_loopback_stats_attrs(field)				\
+do {								\
 	gb_loopback_ro_stats_attr(field, min, u);		\
 	gb_loopback_ro_stats_attr(field, max, u);		\
-	gb_loopback_ro_avg_attr(field)
+	gb_loopback_ro_avg_attr(field)				\
+} while (0)
 
 #define gb_loopback_attr(field, type)					\
 static ssize_t field##_show(struct device *dev,				\
-- 
2.7.4