linux-kernel - Re: [PATCH 1/1] staging: iio: cdc: fix improper return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c6e37ee-43bf-78a8-9aa9-7103715fd9e3@kernel.org>
Date:   Sun, 4 Dec 2016 10:58:21 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Pan Bian <bianpan201602@....com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Pan Bian <bianpan2016@....com>
Subject: Re: [PATCH 1/1] staging: iio: cdc: fix improper return value

On 03/12/16 13:44, Pan Bian wrote:
> From: Pan Bian <bianpan2016@....com>
> 
> At the end of function ad7150_write_event_config(), directly returns 0.
> As a result, the errors will be ignored by the callers. It may be better 
> to return variable "ret".
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/cdc/ad7150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index 5578a07..50a5b0c2 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -274,7 +274,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev,
>  error_ret:
>  	mutex_unlock(&chip->state_lock);
>  
> -	return 0;
> +	return ret;
>  }
>  
>  static int ad7150_read_event_value(struct iio_dev *indio_dev,
>