linux-kernel - Re: [PATCH 1/1] edac: fix improper return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161204100734.glm3eutpsw3h22fm@pd.tnic>
Date:   Sun, 4 Dec 2016 11:07:34 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Pan Bian <bianpan201604@....com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pan Bian <bianpan2016@....com>
Subject: Re: [PATCH 1/1] edac: fix improper return value

On Sun, Dec 04, 2016 at 02:07:18PM +0800, Pan Bian wrote:
> From: Pan Bian <bianpan2016@....com>
> 
> When the call to zalloc_cpumask_var() fails, returning "false" seems
> improper. The real value of macro "false" is 0, and 0 means no error.
> This patch fixes the bug, returning "-ENOMEM".
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071

That bugzilla entry wasn't really needed.

> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/edac/amd64_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied,
thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.