linux-kernel - Re: [PATCH]PTP:PTP_CHARDEV:add input parameters check to avoid the NULL pointer reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20161205083207.GB18980@localhost.localdomain>
Date:   Mon, 5 Dec 2016 09:32:07 +0100
From:   Richard Cochran <richardcochran@...il.com>
To:     Deng Feng <feng.deng@...tina-Access.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "cxdx2006@...il.com" <cxdx2006@...il.com>
Subject: Re: [PATCH]PTP:PTP_CHARDEV:add input parameters check to avoid the
 NULL pointer reference

On Mon, Dec 05, 2016 at 08:02:02AM +0000, Deng Feng wrote:
> When we call one function which contained pointers as input parameters,
> we must check the pointers are NULL or not before we make use of them,
> which avoid the NULL pointer reference .

NAK.

These functions belong to an internal kernel API, and the callers
always provide non-NULL arguments.  This isn't some user space
library.

Thanks,
Richard