linux-kernel - Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2016 10:00:52 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Pan Bian <bianpan2016@....com>,
        David Vrabel <david.vrabel@...rix.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xenproject.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure

On 05/12/16 09:22, Pan Bian wrote:
> Variable err is initialized with 0. As a result, the return value may 
> be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
> the bug, initializing err with "-ENOMEM".
> 
> v1 is reviewed by: Juergen Gross <jgross@...e.com>

I didn't say so.

> Signed-off-by: Pan Bian <bianpan2016@....com>

Now I do:

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen

> ---
>  drivers/xen/xenbus/xenbus_probe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index 33a31cf..8178d5b 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -702,7 +702,7 @@ static int __init xenbus_probe_initcall(void)
>   */
>  static int __init xenstored_local_init(void)
>  {
> -	int err = 0;
> +	int err = -ENOMEM;
>  	unsigned long page = 0;
>  	struct evtchn_alloc_unbound alloc_unbound;
>  
>