linux-kernel - Re: [PATCH 1/1] input: usbhid: fix improper check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1480928863.2206.1.camel@suse.com>
Date:   Mon, 05 Dec 2016 10:07:43 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Pan Bian <bianpan201603@....com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-usb@...r.kernel.org,
        Pan Bian <bianpan2016@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] input: usbhid: fix improper check

On Sun, 2016-12-04 at 13:10 +0800, Pan Bian wrote:
> From: Pan Bian <bianpan2016@....com>
> 
> Function hid_post_reset() returns 0 on success, or 1 on failures.

It seems like hid_post_reset() is buggy in not returning
a proper error code in the failure case. So your diagnosis
is right, but the fix is at the wrong place.

	Regards
		Oliver