linux-kernel - Re: [PATCH] vt: fix Scroll Lock LED trigger name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161205162326.GC6206@var.bordeaux.inria.fr>
Date:   Mon, 5 Dec 2016 17:23:26 +0100
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Pavel Machek <pavel@....cz>
Cc:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vt: fix Scroll Lock LED trigger name

Hello,

Pavel Machek, on Mon 05 Dec 2016 14:47:43 +0100, wrote:
> > There is a disagreement between drivers/tty/vt/keyboard.c and
> > drivers/input/input-leds.c with regard to what is a Scroll Lock LED
> > trigger name: input calls it "kbd-scrolllock", but vt calls it
> > "kbd-scrollock" (two l's).
> > This prevents Scroll Lock LED trigger from binding to this LED by default.
> > 
> > Since it is a scroLL Lock LED, this interface was introduced only about a
> > year ago and in an Internet search people seem to reference this trigger
> > only to set it to this LED let's simply rename it to "kbd-scrolllock".
> > 
> > Also, it looks like this was supposed to be changed before this code was
> > merged: https://lkml.org/lkml/2015/6/9/697 but it was done only on
> > the input side.
> > 
> > Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
> > ---
> >  drivers/tty/vt/keyboard.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
> > index d5d81d4d3c04..3dd6a491cdba 100644
> > --- a/drivers/tty/vt/keyboard.c
> > +++ b/drivers/tty/vt/keyboard.c
> > @@ -982,7 +982,7 @@ static void kbd_led_trigger_activate(struct led_classdev *cdev)
> >  	KBD_LED_TRIGGER((_led_bit) + 8, _name)
> >  
> >  static struct kbd_led_trigger kbd_led_triggers[] = {
> > -	KBD_LED_TRIGGER(VC_SCROLLOCK, "kbd-scrollock"),
> > +	KBD_LED_TRIGGER(VC_SCROLLOCK, "kbd-scrolllock"),
> 
> Would it be feasible to rename "VC_SCROLLOCK" to "VC_SCROLLLOCK", too?

Well, no, that's a misnamed userland API.

Samuel