linux-kernel - Re: [PATCH 3/5] MIPS: Only change $28 to thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1612051705280.6743@tp.orcam.me.uk>
Date:   Mon, 5 Dec 2016 17:22:41 +0000
From:   "Maciej W. Rozycki" <macro@...tec.com>
To:     Matt Redfearn <matt.redfearn@...tec.com>
CC:     Ralf Baechle <ralf@...ux-mips.org>, <linux-mips@...ux-mips.org>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>,
        James Hogan <james.hogan@...tec.com>,
        Paul Burton <paul.burton@...tec.com>
Subject: Re: [PATCH 3/5] MIPS: Only change $28 to thread_info if coming from
 user mode

On Mon, 5 Dec 2016, Matt Redfearn wrote:

> Ah yes, I missed the .set reorder above the EVA ifdef and just included the
> .set reorder as the similar snippet here:
> http://lxr.free-electrons.com/source/arch/mips/include/asm/stackframe.h#L149

 That's a global `.set reorder' for the whole of SAVE_SOME, just as I 
suggested for all the macros here.

 Then a temporary `.set noreorder' override follows just for the manually 
scheduled BLTZ/MOVE sequence, where someone has later inserted a whole 
CONFIG_EVA block.  As I noted this temporary override is unnecessary.  
Incidentally it does not harm the CONFIG_EVA block either, because EVA 
processors have MFC0 interlocked.

 NB I think the MFC0 macro ought to be called REG_MFC0, to avoid confusion 
and for consistency with the rest of such macros.

  Maciej