linux-kernel - Re: [PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOw6vbKAfShPaapf73rOkB8pQXOOCphB7ESu4eZDE7nqqUQVWw@mail.gmail.com>
Date:   Mon, 5 Dec 2016 13:19:59 -0500
From:   Sean Paul <seanpaul@...omium.org>
To:     Pan Bian <bianpan2016@....com>
Cc:     Dave Airlie <airlied@...hat.com>, David Airlie <airlied@...ux.ie>,
        Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Christian König <christian.koenig@....com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable

On Sat, Dec 3, 2016 at 10:11 AM, Pan Bian <bianpan2016@....com> wrote:
> In function qxl_release_alloc(), when kmalloc() returns a NULL pointer,
> it returns value 0 and parameter *ret is uninitialized. 0 means no error
> to the callers of qxl_release_alloc(). The callers keep going and will
> try to reference the uninitialized variable. This patch fixes the bug,
> returning "-ENOMEM" when kmalloc() fails.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188911
>
> Signed-off-by: Pan Bian <bianpan2016@....com>

Applied to drm-misc, with subject prefix tweak s_gpu: drm: qxl_drm/qxl_

Thanks!

Sean

> ---
>  drivers/gpu/drm/qxl/qxl_release.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c
> index cd83f05..e6daa70 100644
> --- a/drivers/gpu/drm/qxl/qxl_release.c
> +++ b/drivers/gpu/drm/qxl/qxl_release.c
> @@ -133,7 +133,7 @@ static long qxl_fence_wait(struct fence *fence, bool intr, signed long timeout)
>         release = kmalloc(size, GFP_KERNEL);
>         if (!release) {
>                 DRM_ERROR("Out of memory\n");
> -               return 0;
> +               return -ENOMEM;
>         }
>         release->base.ops = NULL;
>         release->type = type;
> --
> 1.9.1
>
>