linux-kernel - Re: [PATCH 1/1] net: usb: set error code when usb_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161205.132748.1851184102764779599.davem@davemloft.net>
Date:   Mon, 05 Dec 2016 13:27:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     bianpan2016@....com
Cc:     woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

From: Pan Bian <bianpan2016@....com>
Date: Sat,  3 Dec 2016 19:24:48 +0800

> In function lan78xx_probe(), variable ret takes the errno code on
> failures. However, when the call to usb_alloc_urb() fails, its value
> will keeps 0. 0 indicates success in the context, which is inconsistent
> with the execution result. This patch fixes the bug, assigning
> "-ENOMEM" to ret when usb_alloc_urb() returns a NULL pointer.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188771
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Applied.