linux-kernel - Re: [PATCH] Yama: allow access for the current ptrace parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKnAgsSiJ0SPkGfcomycRmUpQf5Kb4xdFJh6G8YAqn9Ow@mail.gmail.com>
Date:   Mon, 5 Dec 2016 11:38:13 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Josh Stone <jistone@...hat.com>
Cc:     James Morris <james.l.morris@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        linux-security-module <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH] Yama: allow access for the current ptrace parent

On Mon, Dec 5, 2016 at 11:13 AM, Josh Stone <jistone@...hat.com> wrote:
> On 12/02/2016 03:27 PM, Kees Cook wrote:
>>> +       /* If there's already an active tracing relationship, then make an
>>
>> I'll adjust the comment style here and add it to my tree for -next.
>
> Thanks!
>
> I guess the tweak is that it should have an empty "/*" line?
>
> FWIW, checkpatch.pl doesn't warn about this -- perhaps it should?
> I only see the opposite check for NETWORKING_BLOCK_COMMENT_STYLE.

Hrm, I thought it did warn. But yeah, the networking subsystem uses
this style but everywhere else doesn't. :P Wheee. :)

-Kees

-- 
Kees Cook
Nexus Security