linux-kernel - Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161205205116.GA31322@mwanda>
Date:   Mon, 5 Dec 2016 23:51:16 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Fernando Apesteguia <fernando.apesteguia@...il.com>
Cc:     lidza.louina@...il.com, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote:
> For the first lines of the patch, I opted to create a small function
> instead of breaking the the line in a weird way.

These first ones are the nice.

> @@ -2511,13 +2516,15 @@ static int dgnc_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
>  				if (ch->ch_tun.un_flags & (UN_LOW | UN_EMPTY)) {
>  					ch->ch_tun.un_flags &=
>  						~(UN_LOW | UN_EMPTY);
> -					wake_up_interruptible(&ch->ch_tun.un_flags_wait);
> +					wake_up_interruptible(&ch->ch_tun
> +							.un_flags_wait);


Ugh...  No.  Don't do this.  Just let it go over 80 characters.  Ignore
the warning.

regards,
dan carpenter