lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 4 Dec 2016 20:11:30 -0800 From: Matt Wilson <msw@...n.com> To: Netanel Belgazal <netanel@...apurnalabs.com> CC: <linux-kernel@...r.kernel.org>, <davem@...emloft.net>, <netdev@...r.kernel.org>, <dwmw@...zon.com>, <zorik@...apurnalabs.com>, <alex@...apurnalabs.com>, <saeed@...apurnalabs.com>, <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...apurnalabs.com> Subject: Re: [PATCH V2 net 03/20] net/ena: fix queues number calculation On Sun, Dec 04, 2016 at 03:19:21PM +0200, Netanel Belgazal wrote: > The ENA driver tries to open a queue per vCPU. > To determine how many vCPUs the instance have it uses num_possible_cpus > while it should have use num_online_cpus instead. use () when referring to functions: num_possible_cpus(), num_online_cpus(). > Signed-off-by: Netanel Belgazal <netanel@...apurnalabs.com> Reviewed-by: Matt Wilson <msw@...zon.com> > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c > index 397c9bc..224302c 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c > @@ -2667,7 +2667,7 @@ static int ena_calc_io_queue_num(struct pci_dev *pdev, > io_sq_num = get_feat_ctx->max_queues.max_sq_num; > } > > - io_queue_num = min_t(int, num_possible_cpus(), ENA_MAX_NUM_IO_QUEUES); > + io_queue_num = min_t(int, num_online_cpus(), ENA_MAX_NUM_IO_QUEUES); > io_queue_num = min_t(int, io_queue_num, io_sq_num); > io_queue_num = min_t(int, io_queue_num, > get_feat_ctx->max_queues.max_cq_num);
Powered by blists - more mailing lists