[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161205205226.GB31322@mwanda>
Date: Mon, 5 Dec 2016 23:52:26 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Laurentiu Tudor <laurentiu.tudor@....com>
Cc: Stuart Yoder <stuart.yoder@....com>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
"agraf@...e.de" <agraf@...e.de>,
Ruxandra Ioana Radulescu <ruxandra.radulescu@....com>,
"arnd@...db.de" <arnd@...db.de>, Roy Pledge <roy.pledge@....com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Leo Li <leoyang.li@....com>,
Catalin Horghidan <catalin.horghidan@....com>,
Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and
scatter/gather APIs
On Fri, Dec 02, 2016 at 12:12:14PM +0000, Laurentiu Tudor wrote:
> > +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg)
> > +{
> > + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT);
>
> In other places in this file we don't use the '!!' to convert to bool. Maybe we should drop it here too.
I like the explicit "!!". I think it makes the code more obvious since
all the information is on one line.
regards,
dan carpenter
Powered by blists - more mailing lists