linux-kernel - Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161205205339.GC31243@mwanda>
Date:   Mon, 5 Dec 2016 23:53:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Brian Masney <masneyb@...tation.org>
Cc:     jic23@...nel.org, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, lars@...afoo.de,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        ldewangan@...dia.com, pmeerw@...erw.net, knaack.h@....de
Subject: Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between
 signed and unsigned integers

On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote:
> Fixed warning found by make W=2 to reduce the amount of build noise:
> 
> warning: comparison between signed and unsigned integer expressions
> [-Wsign-compare]

Ugh...  Please don't do work arounds for nonsense warnings.  W=2 is so
stupid.  Better to just grep -v this warning instead of trying to please
a broken static analysis.  Warnings like this are why it's disabled by
default.

regards,
dan carpenter