linux-kernel - Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2DA842C3-D6EF-472B-9187-A6C681ACD863@intel.com>
Date:   Mon, 5 Dec 2016 17:44:09 -0500
From:   Oleg Drokin <oleg.drokin@...el.com>
To:     Pan Bian <bianpan201602@....com>
Cc:     Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org SUBSYSTEM" <devel@...verdev.osuosl.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Pan Bian <bianpan2016@....com>
Subject: Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value


On Dec 3, 2016, at 7:52 AM, Pan Bian wrote:

> From: Pan Bian <bianpan2016@....com>
> 
> At the end of function lstcon_group_info(), "return 0" seems improper.
> It may be better to return the value of rc.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Acked-by: Oleg Drokin <oleg.drokin@...el.com>

> ---
> drivers/staging/lustre/lnet/selftest/console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
> index a0fcbf3..9a7c41a 100644
> --- a/drivers/staging/lustre/lnet/selftest/console.c
> +++ b/drivers/staging/lustre/lnet/selftest/console.c
> @@ -820,7 +820,7 @@
> 
> 	lstcon_group_decref(grp);
> 
> -	return 0;
> +	return rc;
> }
> 
> static int
> -- 
> 1.9.1
>